Alexander Kachkaev
Alexander Kachkaev
Alternatively, we could probably allow this in `.markdownlint.json`, [like in Prettier](https://prettier.io/docs/en/configuration.html#sharing-configurations): ```json "@company/markdownlint-config" ``` Ideally, this should resolve to _discovered package dir_ → `main` file in `package.json`. To avoid using...
👋 @DavidAnson, thanks for your reply! I understand your motivation to not add `*.js` autodiscovery just because others do and, to be honest, if we dig deeper into the problem...
When you call `require.resolve("some-package-name")`, Node.js opens `package.json` in `./node_modules/some-package-name` and searches for the value in the `main` field (e.g. `"main": "whatever.json"`). Then it concatenates two path segments and returns `./node_modules/some-package-name/whatever.json`....
Conceptually yes, there could be two types of packages: those saying `"main": "whatever.json"` and `"main": "whatever.js"`. That does not change the game though, because it’s already possible to say `"extends":...
I see your point @DavidAnson. WDYT of replacing `path.resolve` with `require.resolve` in `markdownlint-cli` though? This does not affect security, yet will improve this use case: https://github.com/kachkaev/njt/blob/24dc55ef55d1cd2b994a5e7f3eae0af5ed8bb565/.markdownlint.json#L2
Hey David, thanks for the follow up! I’ll try testing the new CLI performance over the weekend, fingers crossed! I understand that the `.markdownlintignore` approach I’ve shared may look a...
I ran my reproduction steps, but replace `markdownlint` with `markdownlint-cli2`. Running `yarn markdownlint-cli2 "**/*"` took less than a second instead of >100 seconds! 🎉 Many thanks for your work @DavidAnson,...
Just tried `[email protected]` in a real project in which I experienced slow performance with `[email protected]`. Seeing: ``` RangeError: Maximum call stack size exceeded at main (/path/to/project/node_modules/markdownlint-cli2/markdownlint-cli2.js:179:30) at async /path/to/project/node_modules/markdownlint-cli2/markdownlint-cli2.js:356:9 error...
Postponing at least till `dev/graph` is merged
I faced the same issue after updating deps in [graphiql-workspace-app](https://gitlab.com/kachkaev/graphiql-workspace-app) (haven't pushed the result yet). The component loads, but the browser console is full of warnings. What did you end...