specimen-skeleton icon indicating copy to clipboard operation
specimen-skeleton copied to clipboard

build:* and start:* need single quotes to work on macOS

Open twardoch opened this issue 1 year ago • 1 comments

When running 'yarn build' or 'yarn start' on macOS with Bash & Node v21.1.0, you get an error because * gets interpreted as a glob pattern. Surround the specs with ' to make it work.

What

Explain what changes inside the code, this can be as simple or complicated as you want as long as it's clear

Why

Explain why these things are changes. This explanation is for your colleagues and your future self.

Code Review

Please consider the following checklist when reviewing this Pull Request.
More background and details here.

  • [ ] Does the code actually solve the problem it was meant to solve?
  • [ ] Is the code covered by unit tests? Integration tests?
  • [ ] Does anything here need documentation? (Focus on why, not what.)
  • [ ] Does any of this code deal with privacy sensitive information or affects security? Ask an additional reviewer.
  • [ ] Is the code easy to understand and change in the future?
  • [ ] Is the same code or concept duplicated? Find a balance between DRYness and readability.
  • [ ] Does the code reasonably adhere to the Kabisa coding standards?
  • [ ] Be kind.

twardoch avatar Jan 02 '24 16:01 twardoch

@twardoch I completely missed this PR, thanks for your contribution, and your patience!

RoelN avatar May 17 '24 16:05 RoelN