Karl Bergström
Karl Bergström
I think a distinction between 2D and 3D elements in the form of a Dimensions is good, though I believe it would be cleaner to make Transform2D a strict superset...
@jojolepro From a tooling perspective, I disagree. Tools would most likely have an easier time to work with a superset of Transform than a very different data representation. I also...
Oh, one more thing I thought about: Pivots. Since the Transform2D concept defines dimensions, it will be essential to be able to define a pivot point for rotations.
I implemented that here: https://github.com/amethyst/serde-diff/commit/5afe403d0d4fb80f5d072f4836f1a72bf6da6dff
Use `Diff::serializable_with_mode(old, new, FieldPathMode::Index)` instead of `Diff::serializable`. I don't like this API though, I want to it to be more like a `Config` struct so that adding/removing options doesn't break...
Perhaps @leudz could check why this is?
I suppose the issue is that the benchmark creates a new World in the bench function, and in shipyard's case, creating a new World will create a new threadpool which...
@leudz Do you have any opinion on how to solve this?