Mieszko Wawrzyniak

Results 18 comments of Mieszko Wawrzyniak

Sure, I'll update it in the free time and ping you

@hansihe refactored and tested on my project

> I think the solution for you is to not use the erlang:24 tag as it is a mutable tag. If you want to have a stable tag you should...

Sure I’ll take care of this > On 12 Sep 2019, at 04:51, Powell Kinney wrote: > > @kaaboaye This is a great addition, thank you. It makes sense to...

I've added test making use of dynamic load. However, is this output with a couple of panics is expected?

I can fix this test for Windows but I could figure out some other case which doesn’t rely on platform specific API. Windows fix would work as an example usage...

Looking into the issue of initialization I've realized that those modules can be also unloaded while updating. `erl_nif` exposes [unload](https://www.erlang.org/doc/man/erl_nif.html#initialization) function for that purpose. It's mainly development issue. Hot module...

> But maybe we need to figure out how to handle unload. I think `unsafe { DATASET = None }` should be enough. Rust should drop `Some(dataset)` after that. Assuming...

Added windows support, all tests are green on windows now.