haxe-react icon indicating copy to clipboard operation
haxe-react copied to clipboard

Published 20 hours ago • verified publisher icon kLabz

Inconsistent defaultProps behavior in debug / no debug mode

Open djaonourside opened this issue 6 years ago • 2 comments

Hi, Rudy! It looks like react-next has this bug too. https://github.com/massiveinteractive/haxe-react/issues/131

djaonourside avatar Oct 13 '19 21:10 djaonourside

Can you check if latest git (with this commit https://github.com/kLabz/haxe-react/commit/138cc016470fabdba5583ccea98a84f4483b8cbf) fixes your original issue and works for your project?

If it works I'll make a PR to haxe-react too. Note that this won't be the final fix; I still need to add tests to check other cases (spreads, etc.) and this can be optimized (by skipping constant arguments, etc.). I might end up calling a "native" Object.assign to get the same behavior as react's.

kLabz avatar Oct 14 '19 05:10 kLabz

Confirm, the fix solves the issue for my project.

djaonourside avatar Oct 14 '19 06:10 djaonourside