!Str prefix for interactive keys to pass a string

Open DAmesberger opened this issue 2 years ago • 2 comments

This is a proposal for implementing a !Str prefix for keys. Currently, the default delay is not taken into account, but this would work:

- !Interactive
  keys:
    - !Str hello
    - 2s
    - ^X
    - n

Feb 21 '24 09:02 DAmesberger

Thanks for the PR! I think it might be better to implement this by keeping the Key enum the same and instead change the deserialization for the keys field of Instruction::Interactive via #[serde(deserialize_with = "..."].

Feb 27 '24 21:02 k9withabone

@DAmesberger is it ok if I close this and work on the alternative I described myself? Or are you still interested in working on this?

Apr 09 '24 20:04 k9withabone

Sorry, I completely missed that comment. Sure, go ahead, it was just a quick fix and I am not that deep into that codebase, and time is scarce at the moment on my side, so currently I would not have time anyways.

Jun 17 '24 14:06 DAmesberger