k8ssandra-operator icon indicating copy to clipboard operation
k8ssandra-operator copied to clipboard

Vector for Cassandra should be enabled by default

Open adejanovski opened this issue 2 years ago • 3 comments

Since cass-operator now uses Vector for the server-system-logger container, having to enable Vector through .cassandra.telemetry.vector.enabled doesn't make sense anymore.

We should consider that Vector is always enabled, which means that we'll have to duplicate the IsVectorEnabled() method into IsVectorEnabledForCassandra() which will return true if .cassandra.telemetry.vector.enabled is nil. The alternative would be to ignore the enabled field for Cassandra and consider Vector as always enabled.

┆Issue is synchronized with this Jira Story by Unito

adejanovski avatar May 10 '23 09:05 adejanovski

@burmanm, wdyt?

adejanovski avatar May 10 '23 09:05 adejanovski

Well, one we could think of (if we want) is that you can actually also disable Vector in cass-operator (I forgot this), there's a Spec setting that allows disabling the ServerSystemLogger. That feature is not implemented at all in k8ssandra-operator I think, but would we want that ? So setting "enabled" explicitly to false would actually trigger removal of console logging? Not sure if users would understand that, but ..

burmanm avatar May 10 '23 09:05 burmanm

I think that's a good idea. If it's properly documented (in the docs and in the CRD) then it does make sense 👍

adejanovski avatar May 10 '23 11:05 adejanovski