k8ssandra-operator icon indicating copy to clipboard operation
k8ssandra-operator copied to clipboard
verified publisher icon k8ssandra

Don't set jmxremote.authenticate system property by default

Open olim7t opened this issue 2 years ago • 5 comments

What this PR does:

Which issue(s) this PR fixes: Fixes #

Checklist

  • [x] Changes manually tested
  • [x] Automated Tests added/updated
  • [ ] Documentation added/updated
  • [ ] CHANGELOG.md updated (not required for documentation PRs)
  • [x] CLA Signed: DataStax CLA

olim7t avatar Mar 24 '23 00:03 olim7t

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

github-actions[bot] avatar Mar 24 '23 00:03 github-actions[bot]

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.5% 5.5% Duplication

sonarqubecloud[bot] avatar Mar 24 '23 00:03 sonarqubecloud[bot]

By making this change we're changing our defaults. I think we should allow to opt out of having jmx auth enabled instead of changing the default, which will trigger a rolling restart upon upgrade ;)

adejanovski avatar Mar 24 '23 05:03 adejanovski

By making this change we're changing our defaults. I think we should allow to opt out of having jmx auth enabled instead of changing the default, which will trigger a rolling restart upon upgrade ;)

I don't know, that sounds overkill for such a small change.

olim7t avatar Mar 24 '23 18:03 olim7t

@olim7t, should we close this and fully remove changes we make on the JMX config now that Reaper moved to using the management api?

adejanovski avatar Jan 15 '24 10:01 adejanovski