k8ssandra-operator icon indicating copy to clipboard operation
k8ssandra-operator copied to clipboard

Add PullSecret string field for the Image instead of PullSecretRef

Open burmanm opened this issue 2 months ago • 2 comments

What this PR does: Adds "PullSecret" to the Image struct that has precedence over PullSecretRef. This is to ensure the compatibility with the cass-operator Image type (and to allow easier migration in the future) and adheres to the API documentation in Kubernetes which states for LocalObjectReference:

"// New uses of this type are discouraged because of difficulty describing its usage when embedded in APIs."

Also, deprecate PullSecretRef so we can in the future migrate away from it.

Which issue(s) this PR fixes: Fixes #

Checklist

  • [ ] Changes manually tested
  • [x] Automated Tests added/updated
  • [ ] Documentation added/updated
  • [ ] CHANGELOG.md updated (not required for documentation PRs)
  • [x] CLA Signed: DataStax CLA

burmanm avatar Sep 24 '25 14:09 burmanm

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

github-actions[bot] avatar Sep 24 '25 14:09 github-actions[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
6.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

sonarqubecloud[bot] avatar Sep 24 '25 14:09 sonarqubecloud[bot]