cass-operator icon indicating copy to clipboard operation
cass-operator copied to clipboard
verified publisher icon k8ssandra

Extend current ImageConfig to allow more values to images as well as …

Open burmanm opened this issue 2 years ago • 1 comments

What this PR does: Part of the implementation of https://github.com/k8ssandra/k8ssandra-operator/issues/532

Which issue(s) this PR fixes: Fixes https://github.com/k8ssandra/k8ssandra-operator/issues/532 Fixes #636

Checklist

  • [ ] Changes manually tested
  • [x] Automated Tests added/updated
  • [ ] Documentation added/updated
  • [x] CHANGELOG.md updated (not required for documentation PRs)
  • [x] CLA Signed: DataStax CLA

burmanm avatar Mar 13 '23 14:03 burmanm

PR still missing modifications to ImagePullPolicy for certain imageTypes in the CassandraDatacenter spec..

burmanm avatar Mar 13 '23 14:03 burmanm

@burmanm, should we close this? We've had some evolutions lately that might cover this already?

adejanovski avatar Nov 15 '24 14:11 adejanovski

You mean merge? We haven't merged any changes to master.

burmanm avatar Nov 15 '24 14:11 burmanm

no, I mean is it still something we want to do? Recently you've extended the capabilities of the imageConfig, allowing to add new images dynamically and dealing with defaults more efficiently.

adejanovski avatar Nov 15 '24 15:11 adejanovski

Recently you've extended the capabilities of the imageConfig, allowing to add new images dynamically and dealing with defaults more efficiently.

Yes, in this PR, not anywhere else. We haven't changed imageConfig properties in anyway elsewhere. That includes HCD version overrides or namespace overrides for airgaps. They are all in this PR only.

Do we not want those features anymore? I thought there was a customer request for the override namespace registry.

burmanm avatar Nov 15 '24 15:11 burmanm