whereabouts [POC] lease lock per IP pool

[POC] lease lock per IP pool

Open adrianchiris opened this issue 2 years ago • 4 comments

This is a POC level code for changing lease/leaderElection usage by whereabouts from a global lease to a per pool lease.

What this PR does / why we need it: This PR is related to #313 and is used as additional context on the potential changes proposed.

Mar 29 '23 12:03 adrianchiris

I'd say this makes sense without looking in detail !

Please be patient while we sort this out.

If you can, please rebase and ensure the tests are passing.

@xagent003 could you review ?

Mar 21 '24 08:03 maiqueb

Hi @maiqueb I reviewed. the lease lock change looks good, but I'd like to understand the other change for moving around the overlappingranges code.

BTW we tested out this code and it does appear to improve performance.

Mar 27 '24 07:03 xagent003

Hi @maiqueb I reviewed. the lease lock change looks good, but I'd like to understand the other change for moving around the overlappingranges code.

@adrianchiris could you split this change to another commit and explain its goal in the commit msg ?

BTW we tested out this code and it does appear to improve performance.

Thank you @xagent003 . I really appreciate your help.

Mar 27 '24 08:03 maiqueb

@adrianchiris could you split this change to another commit and explain its goal in the commit msg ?

Hey @maiqueb, ATM i have no bandwidth to work on this unfortunately.

Apr 07 '24 10:04 adrianchiris