[BUG] network controller fails on node restart

[deekue]

Describe the bug when a node is restarted the Whereabouts pod starts but the network controller fails to connect to the k8s API and retrieve the network-attachment-definitions. The pod continues, even though it doesn't appear to be able to assign addresses.

if the pod is manually deleted it does restart successfully

Expected behavior the pod should terminate if it can't assign addresses, so that k8s can restart it.

To Reproduce Steps to reproduce the behavior:

1. drain node
2. reboot node
3. check logs of pod

Environment:

• Whereabouts version : v0.5.3
• Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.3", GitCommit:"aef86a93758dc3cb2c658dd9657ab4ad4afc21cb", GitTreeState:"clean", BuildDate:"2022-07-13T14:30:46Z", GoVers
ion:"go1.18.3", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.4
Server Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.3", GitCommit:"aef86a93758dc3cb2c658dd9657ab4ad4afc21cb", GitTreeState:"clean", BuildDate:"2022-07-13T14:23:26Z", GoVers
ion:"go1.18.3", Compiler:"gc", Platform:"linux/amd64"}

• Network-attachment-definition: storage-macvlan-whereabouts.yaml
• Whereabouts configuration (on the host): config
• OS (e.g. from /etc/os-release): Talos v1.20-alpha.1
• Kernel (e.g. uname -a): 5.15.57-talos
• Others: N/A

Additional info / context whereabouts-startup-failure.log.gz

[nicklesimba]

Hello, what kind of cluster are you using? Upstream kubernetes?

[deekue]

I'm using the kubernetes included with Talos

$ kubectl version --short
Flag --short has been deprecated, and will be removed in the future. The --short output will become the default.
Client Version: v1.24.3
Kustomize Version: v4.5.4
Server Version: v1.24.3