whereabouts
whereabouts copied to clipboard
Published
20 hours ago •
k8snetworkplumbingwg
k8snetworkplumbingwg
Remove controller runtime
Remove the controller-runtime dependency from the project.
Simplifies upgrading k8s dependencies going forward.
Depends-on: #265
Pull Request Test Coverage Report for Build 2889420756
- 25 of 62 (40.32%) changed or added relevant lines in 4 files are covered.
- 5 unchanged lines in 2 files lost coverage.
- Overall coverage increased (+4.6%) to 69.659%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| pkg/reconciler/iploop.go | 1 | 3 | 33.33% |
| pkg/controlloop/pod.go | 11 | 15 | 73.33% |
| cmd/whereabouts.go | 9 | 40 | 22.5% |
| <!-- | Total: | 25 | 62 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| pkg/controlloop/pod.go | 1 | 83.0% |
| pkg/reconciler/iploop.go | 4 | 75.56% |
| <!-- | Total: | 5 |
| Totals | |
|---|---|
| Change from base Build 2882834733: | 4.6% |
| Covered Lines: | 900 |
| Relevant Lines: | 1292 |
💛 - Coveralls
FWIW, everything installs normally as a user, and works with my current test. OK to proceed. Thanks Miguel :+1:
