sriov-network-operator icon indicating copy to clipboard operation
sriov-network-operator copied to clipboard

Published 20 hours ago • verified publisher icon k8snetworkplumbingwg

chore: bump libovsdb lib

Open adrianchiris opened this issue 3 months ago • 4 comments

current lib path is deprecated, use github.com/ovn-kubernetes/libovsdb instead

adrianchiris avatar Aug 26 '25 17:08 adrianchiris

Thanks for your PR, To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] avatar Aug 26 '25 17:08 github-actions[bot]

:/ I was hoping this would be just a quick fix.

swtaylor avatar Aug 26 '25 18:08 swtaylor

Looks like this is how they are handling it upstream: https://github.com/ovn-kubernetes/libovsdb/blob/18e5bb119abe1e29ca07b02083ebdef39242e6ff/client/client_test.go#L958-L963

swtaylor avatar Aug 27 '25 21:08 swtaylor

looks like changes in our code is needed to support this bump.

SchSeba avatar Sep 25 '25 08:09 SchSeba

Pull Request Test Coverage Report for Build 19210276708

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 62.358%
Files with Coverage Reduction New Missed Lines %
controllers/helper.go 1 70.99%
<!-- Total: 1
Totals Coverage Status
Change from base Build 19210182850: -0.008%
Covered Lines: 8752
Relevant Lines: 14035
💛 - Coveralls

coveralls avatar Nov 09 '25 15:11 coveralls

@SchSeba this can be merged IMO fixed remaining issue and CI is green

adrianchiris avatar Nov 10 '25 09:11 adrianchiris