sriov-network-operator
sriov-network-operator copied to clipboard
k8snetworkplumbingwg
Use helm values to expand the supported NICs
The supported-nic-ids ConfigMap is a whitelist that includes details of some NICs. However, the user might want to add other NICs to that list so that the sriov operator works in his env.
The only way to do it right now is deploying the sriov-operator, editing that configmap and then restarting some of the sriov-operator components so that the new config is consumed.
This PR adds a new way to do it which can be easily automated: use a values.yaml parameter in the helm chart to include extra NICs. We can add the extra NICs when installing the sriov-operator, thus not requiring to restart any of the components
Thanks for your PR, To run vendors CIs use one of:
/test-all: To run all tests for all vendors./test-e2e-all: To run all E2E tests for all vendors./test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.
To skip the vendors CIs use one of:
/skip-all: To skip all tests for all vendors./skip-e2e-all: To skip all E2E tests for all vendors./skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Pull Request Test Coverage Report for Build 9060118246
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- 4 unchanged lines in 1 file lost coverage.
- Overall coverage decreased (-0.03%) to 39.634%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| controllers/drain_controller.go | 4 | 67.1% |
| <!-- | Total: | 4 |
| Totals | |
|---|---|
| Change from base Build 8958656332: | -0.03% |
| Covered Lines: | 5007 |
| Relevant Lines: | 12633 |
💛 - Coveralls
Thanks for your PR, To run vendors CIs use one of:
/test-all: To run all tests for all vendors./test-e2e-all: To run all E2E tests for all vendors./test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.
To skip the vendors CIs use one of:
/skip-all: To skip all tests for all vendors./skip-e2e-all: To skip all E2E tests for all vendors./skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.