sriov-network-operator icon indicating copy to clipboard operation
sriov-network-operator copied to clipboard

Add OVSNetwork CRD and controller for it

Open ykulazhenkov opened this issue 1 year ago • 14 comments
trafficstars

This PR adds OVSNetwork CRD and controller for it.

Context is #640

Depends on: #663. Last two commits to review

ykulazhenkov avatar Mar 05 '24 11:03 ykulazhenkov

Thanks for your PR, To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] avatar Mar 05 '24 11:03 github-actions[bot]

Thanks for your PR, To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] avatar Mar 05 '24 12:03 github-actions[bot]

Thanks for your PR, To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] avatar Mar 05 '24 12:03 github-actions[bot]

Pull Request Test Coverage Report for Build 8893889198

Details

  • 97 of 168 (57.74%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 38.86%

Changes Missing Coverage Covered Lines Changed/Added Lines %
api/v1/helper.go 45 56 80.36%
api/v1/zz_generated.deepcopy.go 33 93 35.48%
<!-- Total: 97 168
Files with Coverage Reduction New Missed Lines %
controllers/drain_controller.go 1 70.36%
<!-- Total: 1
Totals Coverage Status
Change from base Build 8893830201: 0.3%
Covered Lines: 4962
Relevant Lines: 12769

💛 - Coveralls

coveralls avatar Mar 05 '24 12:03 coveralls

Thanks for your PR, To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] avatar Mar 07 '24 08:03 github-actions[bot]

Thanks for your PR, To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] avatar Mar 12 '24 09:03 github-actions[bot]

Thanks for your PR, To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] avatar Mar 13 '24 14:03 github-actions[bot]

Thanks for your PR, To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] avatar Mar 18 '24 13:03 github-actions[bot]

move refactoring commit to a separate PR #663

ykulazhenkov avatar Mar 20 '24 07:03 ykulazhenkov

Thanks for your PR, To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] avatar Mar 20 '24 08:03 github-actions[bot]

Thanks for your PR, To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] avatar Mar 25 '24 13:03 github-actions[bot]

Thanks for your PR, To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] avatar Apr 02 '24 06:04 github-actions[bot]

I removed the note about auto bridge selection. PR to the ovs-cni is not merged and this comment is incorrect at the moment

ykulazhenkov avatar Apr 02 '24 06:04 ykulazhenkov

Thanks for your PR, To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] avatar Apr 30 '24 11:04 github-actions[bot]

@SchSeba can we merge this one ?

adrianchiris avatar May 13 '24 07:05 adrianchiris

closing this one

SchSeba avatar May 13 '24 13:05 SchSeba