sriov-network-operator icon indicating copy to clipboard operation
sriov-network-operator copied to clipboard

Support Deployment of SR-IOV Network Operator via helm

Open adrianchiris opened this issue 4 years ago • 12 comments
trafficstars

This Enhancement proposes to add Helm charts to the project to allow an easy depoyment of sriov-network-operator in a k8s environment.

The charts will be added in a new deployment folder under the project root.

upon release the chart parameter can be modified to point to a release version of sriov network operator images and possibly be made available in a helm repository. one way of doing that is using github pages to host the repository (index file, packaged charts and possibly some project documentation)

However this can be regarded as a followup effort.

adrianchiris avatar Jan 28 '21 15:01 adrianchiris

Helm chars is added in #76. We still need to create helm chart repository to allow people use charts from it

e0ne avatar Apr 06 '21 07:04 e0ne

Discussed the Helm Repository part of this issue in today's community meeting.

having a helm repository is desirable and github pages seems like a viable option to do it. @martinkennelly is also +1 on it.

@zshi-redhat @pliurh do you have any inputs / preferences / objections ?

At the end the user would have to do the following to deploy sriov-network-operator:

$ helm repo sno-repo https://k8snetworkplumbingwg.github.io/sriov-network-operator
$ helm repo update
$ helm install -n sriov-network-operator --create-namespace --wait sriov-network-operator sno-repo/sriov-network-operator

An alternative could be to have a place for the entire org to host project charts (A gh_pages branch in https://github.com/k8snetworkplumbingwg/helm-charts ?) This would need to be raised in the npwg bi-weekly meeting.

A downside for this approach is that it would not be self contained.

adrianchiris avatar Apr 06 '21 15:04 adrianchiris

An alternative could be to have a place for the entire org to host project charts (A gh_pages branch in https://github.com/k8snetworkplumbingwg/helm-charts ?)

I prefer this approach. @dougbtv What's your suggestion?

pliurh avatar Apr 12 '21 06:04 pliurh

It'd be great to see a solution to this. A central repo for helm-charts sounds like the right approach, unfortunately it looks like https://github.com/k8snetworkplumbingwg/helm-charts/ has been abandoned

ianb-mp avatar Apr 30 '24 03:04 ianb-mp

That is fine we can push on having just a github pages to support it

SchSeba avatar Apr 30 '24 12:04 SchSeba

That is fine we can push on having just a github pages to support it

@SchSeba I had a look at this. A common pattern for publishing helm charts is to use the Chart Releaser Github action to update index.yml in gh-pages branch, and push a release & chart tar file to the main/master branch. Alternatively, the chart tar can be stored in gh-pages branch. Before this can be setup, I think the release process needs to be clarified. For example, it looks like releases are currently done manually and not driven from Actions.

ianb-mp avatar May 08 '24 01:05 ianb-mp

Agree that are stuffs we need to talk about will it be possible for you to join our next community meeting?

https://docs.google.com/document/d/1sJQMHbxZdeYJPgAWK1aSt6yzZ4K_8es7woVIrwinVwI/edit

SchSeba avatar May 22 '24 10:05 SchSeba

Agree that are stuffs we need to talk about will it be possible for you to join our next community meeting?

@SchSeba I would like to attend, however that meeting is at midnight in my timezone which makes it difficult for me. BTW, did you mean to post the doc edit link?

ianb-mp avatar May 22 '24 22:05 ianb-mp

sure the link is open to everyone who wants to contribute :)

I am sorry that the time zone doesn't work for you. do you want to open a PR and we can review the PR?

SchSeba avatar Jun 02 '24 12:06 SchSeba

do you want to open a PR and we can review the PR?

@SchSeba to be clear, the PR would be to host helm chart in sriov-network-operator repo (and not use https://github.com/k8snetworkplumbingwg/helm-charts/ repo)?

@dougbtv @e0ne do either of you have thoughts on this? If the 'helm-charts' repo is no longer to be used, it should be archived.

ianb-mp avatar Jun 02 '24 23:06 ianb-mp

I am fine to host the sriov-operator helm in this repo

SchSeba avatar Jun 03 '24 11:06 SchSeba

It looks like this is fixed by #715

GHCR hosts the helm chart which can be used like this:

$ helm install -n sriov-network-operator --create-namespace \
  --version 1.3.0 \
  --set sriovOperatorConfig.deploy=true sriov-network-operator \
  oci://ghcr.io/k8snetworkplumbingwg/sriov-network-operator-chart

ianb-mp avatar Jun 18 '24 01:06 ianb-mp

that is right @ianb-mp closing this issue

SchSeba avatar Aug 19 '24 13:08 SchSeba