sriov-network-operator icon indicating copy to clipboard operation
sriov-network-operator copied to clipboard

Remove inner comparison for numVfs in externally managed

Open mlguerrero12 opened this issue 2 years ago • 7 comments

mlguerrero12 avatar Nov 02 '23 13:11 mlguerrero12

Thanks for your PR, To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] avatar Nov 02 '23 13:11 github-actions[bot]

Thanks for your PR, To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] avatar Nov 02 '23 14:11 github-actions[bot]

Pull Request Test Coverage Report for Build 6783862673

  • 4 of 7 (57.14%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.008%) to 25.472%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/utils/utils.go 0 3 0.0%
<!-- Total: 4 7
Files with Coverage Reduction New Missed Lines %
pkg/webhook/validate.go 2 60.44%
<!-- Total: 2
Totals Coverage Status
Change from base Build 6744863425: 0.008%
Covered Lines: 2335
Relevant Lines: 9167

💛 - Coveralls

coveralls avatar Nov 02 '23 14:11 coveralls

Thanks for your PR, To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] avatar Nov 07 '23 09:11 github-actions[bot]

Thanks for your PR, To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] avatar Nov 07 '23 09:11 github-actions[bot]

Thanks for your PR, To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] avatar Nov 07 '23 11:11 github-actions[bot]

@mlguerrero12 @SchSeba is this PR still relevant ?

adrianchiris avatar Aug 12 '24 10:08 adrianchiris