sriov-network-operator icon indicating copy to clipboard operation
sriov-network-operator copied to clipboard

Published 20 hours ago • verified publisher icon k8snetworkplumbingwg

Support Graceful Shutdown

Open jerpeter1 opened this issue 1 year ago • 13 comments

If the kubelet where the the sriov pod is running has gracefulShutdown configured, we'll delay in preStop for a while if and while /tmp/sriov-delay-shutdown exists, up to a maximum wait that's less than 15 minutes (which is now specified in the daemonset pod's terminationGracePeriodSeconds).

I wrote this as a possible alternative approach to the implementation in this PR, that was reverted last year.

jerpeter1 avatar Mar 07 '23 20:03 jerpeter1

Thanks for your PR, To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] avatar Mar 07 '23 20:03 github-actions[bot]

Thanks for your PR, To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] avatar Mar 08 '23 17:03 github-actions[bot]

Thanks for your PR, To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] avatar Mar 09 '23 04:03 github-actions[bot]

Pull Request Test Coverage Report for Build 4371184613

  • 0 of 26 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 25.64%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/daemon/daemon.go 0 26 0.0%
<!-- Total: 0 26
Files with Coverage Reduction New Missed Lines %
pkg/daemon/daemon.go 2 40.81%
<!-- Total: 2
Totals Coverage Status
Change from base Build 4363097788: -0.03%
Covered Lines: 1944
Relevant Lines: 7582
💛 - Coveralls

coveralls avatar Mar 12 '23 09:03 coveralls

/test-all

jerpeter1 avatar Mar 22 '23 19:03 jerpeter1

/assign @bn222

jerpeter1 avatar Mar 22 '23 19:03 jerpeter1

/assign @SchSeba

jerpeter1 avatar Mar 22 '23 19:03 jerpeter1

Thanks for your PR, To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] avatar Apr 04 '23 13:04 github-actions[bot]

/test-all

jerpeter1 avatar Apr 04 '23 13:04 jerpeter1

Thanks for your PR, To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] avatar May 10 '23 03:05 github-actions[bot]

info on kubernetes graceful node shutdown (for others if needed ...):

https://kubernetes.io/blog/2021/04/21/graceful-node-shutdown-beta/ https://kubernetes.io/docs/concepts/architecture/nodes/#graceful-node-shutdown

adrianchiris avatar Jul 30 '23 10:07 adrianchiris

Hi @jerpeter1 do you still want to push this one? there are some comments from @adrianchiris and this PR needs a rebase

SchSeba avatar Dec 21 '23 07:12 SchSeba

Thanks for your PR, To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] avatar Dec 21 '23 07:12 github-actions[bot]