sriov-network-device-plugin
sriov-network-device-plugin copied to clipboard
k8snetworkplumbingwg
🌱 Making workflows not run on forks.
This PR is making sure that github workflows only run on upstream repo and not on forks.
Pull Request Test Coverage Report for Build 8966156972
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 75.1%
| Totals | |
|---|---|
| Change from base Build 8940131118: | 0.0% |
| Covered Lines: | 2060 |
| Relevant Lines: | 2743 |
💛 - Coveralls
Hi @adilGhaffarDev thanks for the PR! question instead can you just disable the github actions in your fork?
Hi @adilGhaffarDev thanks for the PR! question instead can you just disable the github actions in your fork?
My 2 cents: It makes no sense for fork to try push their images to upstream repository, so wouldn't it make more sense to disable that kind of workflow here than each individual fork doing it? This PR is not disabling build and test type workflows.
Can we get the stuck Mellanox action retriggered to get this merged? Its been pending a long while... @SchSeba
Hi @tuminoid that lane is not critical we are just waiting for another maintainer to approve so we can merge that is the policy
cc @Eoghan1232 @e0ne
Hi @tuminoid that lane is not critical we are just waiting for another maintainer to approve so we can merge that is the policy
cc @Eoghan1232 @e0ne
Oh, ok. GH shows its ready to go, so I guess there is no actual branch protection configured, but just agreed policy? Thanks!