sriov-network-device-plugin
sriov-network-device-plugin copied to clipboard
k8snetworkplumbingwg
Support GetPreferredAllocation
This PR adds support of GetPreferredAllocation API which PR #267 tried to support. This PR is based on the latest master branch to make it easier to review and merge (as I wrote in #267 (comment)).
This PR doesn't include Balanced policy I also mentioned in #267 (comment) because balanced policy doesn't seem to be the scope of PR #267.
Fixes #255
Pull Request Test Coverage Report for Build 3141787359
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 64 of 73 (87.67%) changed or added relevant lines in 4 files are covered.
- 62 unchanged lines in 6 files lost coverage.
- Overall coverage increased (+0.4%) to 77.578%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| pkg/factory/factory.go | 2 | 4 | 50.0% |
| pkg/resources/pool_stub.go | 0 | 3 | 0.0% |
| pkg/resources/allocator.go | 50 | 54 | 92.59% |
| <!-- | Total: | 64 | 73 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| pkg/resources/pciDevice.go | 3 | 61.73% |
| pkg/netdevice/netResourcePool.go | 4 | 87.14% |
| pkg/factory/factory.go | 6 | 90.55% |
| pkg/resources/pool_stub.go | 6 | 60.49% |
| pkg/netdevice/vdpa.go | 15 | 53.97% |
| pkg/resources/server.go | 28 | 85.55% |
| <!-- | Total: | 62 |
| Totals | |
|---|---|
| Change from base Build 2733786348: | 0.4% |
| Covered Lines: | 1640 |
| Relevant Lines: | 2114 |
💛 - Coveralls
@e0ne Thank you for your review! I think I've resolved 2 of your suggestion. Logging for unsupported values is main update, so could you check one? Please let me know if there are anything else I can fix.
@Eoghan1232 I think I resolved all of your suggestion. Please let me know anything else I can fix.
@milran appologies for the delayed review.
I gave this one a proper read, please see comments and thanks for you patience :)
@adrianchiris sorry for late response. I am working on this PR and I will finish by next week.
@adrianchiris @e0ne Thank you for reviewing! I think all of the points are fixed.
I've been working on it for a while, but I've gotten busy. Do you mind asking for a review in a few months?