sriov-network-device-plugin icon indicating copy to clipboard operation
sriov-network-device-plugin copied to clipboard

Published 20 hours ago • verified publisher icon k8snetworkplumbingwg

Introducing FeatureGates and global feature config

Open ipatrykx opened this issue 4 years ago • 4 comments

Regards discussion: https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/issues/321

This PR introduces FeatureGates mechanism similar to one available in Kubernetes, that could be used by users to disable/enable features provided by SR-IOV DP. Additionally added global config structure that could hold configuration of features introduced in the future.

ipatrykx avatar Apr 12 '21 11:04 ipatrykx

Hi, @martinkennelly, @zshi-redhat, @adrianchiris is it possible we could move this thing further? Also tagging @Eoghan1232 who was interested.

ipatrykx avatar Oct 14 '21 12:10 ipatrykx

Pull Request Test Coverage Report for Build 3345652242

  • 0 of 43 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-1.3%) to 75.942%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/sriovdp/main.go 0 43 0.0%
<!-- Total: 0 43
Files with Coverage Reduction New Missed Lines %
cmd/sriovdp/main.go 1 0%
<!-- Total: 1
Totals Coverage Status
Change from base Build 2733786348: -1.3%
Covered Lines: 1572
Relevant Lines: 2070
💛 - Coveralls

coveralls avatar Oct 28 '22 12:10 coveralls

Hi all! This PR has been rebased onto the current master.

ipatrykx avatar Oct 28 '22 13:10 ipatrykx

Is this PR still relevant or we can close it?

SchSeba avatar Dec 21 '23 07:12 SchSeba