multus-cni icon indicating copy to clipboard operation
multus-cni copied to clipboard

delegate plugin delete success, delete cache file

Open gaopeiliang opened this issue 1 year ago • 5 comments

this case should try max to cleanup

sandBox container stop times, but delegated plugin failed (CNI server maybe in starting .... ) , but cache file has been deleted container gc manager clean up forever even though POD has been fully deleted from ETCD POD not find && cache file not find; never clean up, we should try max ...

Add an option allowTryDeleteOnErr in multus conf, allow to try delegate message on such error scene

gaopeiliang avatar Oct 13 '22 06:10 gaopeiliang

This pull request introduces 1 alert when merging 670d4bd1cb5c1272103af2fa27255260acc1cd56 into 1aac2431b86adea46236fc16bcb100330ca28afb - view on LGTM.com

new alerts:

  • 1 for Uncontrolled data used in path expression

lgtm-com[bot] avatar Oct 13 '22 06:10 lgtm-com[bot]

This pull request introduces 1 alert when merging b23724614de213cdc8ef576f2c91f84c92c43396 into 1aac2431b86adea46236fc16bcb100330ca28afb - view on LGTM.com

new alerts:

  • 1 for Uncontrolled data used in path expression

lgtm-com[bot] avatar Oct 14 '22 03:10 lgtm-com[bot]

This pull request introduces 1 alert when merging d7e423c609474087c69ea587718766abd1a768ab into 1aac2431b86adea46236fc16bcb100330ca28afb - view on LGTM.com

new alerts:

  • 1 for Uncontrolled data used in path expression

lgtm-com[bot] avatar Oct 14 '22 04:10 lgtm-com[bot]

This pull request introduces 3 alerts when merging 6aaf5b10bf43f8cef3d7ffe39700d4b0022dfb78 into 1aac2431b86adea46236fc16bcb100330ca28afb - view on LGTM.com

new alerts:

  • 3 for Uncontrolled data used in path expression

lgtm-com[bot] avatar Oct 14 '22 12:10 lgtm-com[bot]

This pull request introduces 1 alert when merging 86226dfabe5232f0bd9195a2456a1ce1403369ec into 1aac2431b86adea46236fc16bcb100330ca28afb - view on LGTM.com

new alerts:

  • 1 for Uncontrolled data used in path expression

lgtm-com[bot] avatar Oct 14 '22 12:10 lgtm-com[bot]

Coverage Status

Coverage decreased (-0.003%) to 68.841% when pulling 86226dfabe5232f0bd9195a2456a1ce1403369ec on gaopeiliang:AllowTryDeleteOnErrOptions into 1aac2431b86adea46236fc16bcb100330ca28afb on k8snetworkplumbingwg:master.

coveralls avatar Oct 24 '22 16:10 coveralls

Thank you for the review process! @gaopeiliang

s1061123 avatar Oct 31 '22 13:10 s1061123