k8sgpt icon indicating copy to clipboard operation
k8sgpt copied to clipboard

fix: set result name and namespace to trivy vulnreport and configaudi…

Open jkleinlercher opened this issue 1 year ago • 3 comments

Closes https://github.com/k8sgpt-ai/k8sgpt-operator/issues/240 and replaces #678

📑 Description

this is the better approach to fix https://github.com/k8sgpt-ai/k8sgpt-operator/issues/240 by using the resource name and namespace of the trivy ConfigAuditReport and VulnerabilityReport

✅ Checks

  • [ ] My pull request adheres to the code style of this project
  • [ ] My code requires changes to the documentation
  • [ ] I have updated the documentation as required
  • [ ] All the tests have passed

ℹ Additional Information

jkleinlercher avatar Jan 15 '24 17:01 jkleinlercher

Thanks for your approval @AlexsJones . Could you please merge it, too? Thank you!

jkleinlercher avatar Jan 22 '24 09:01 jkleinlercher

Mind taking a look at the linter issue locally @jkleinlercher ?

AlexsJones avatar Jan 22 '24 13:01 AlexsJones

Mind taking a look at the linter issue locally @jkleinlercher ?

I needed to increase the timeout in https://github.com/k8sgpt-ai/k8sgpt/pull/869/commits/5840b8ed8dc9bfea818317fa861e679907c734a6 . Don't know why this is needed, but I saw you also already increased the timeout.

jkleinlercher avatar Jan 24 '24 18:01 jkleinlercher

@AlexsJones would merge this? Would be great to have this in the next release :)

jkleinlercher avatar Feb 17 '24 07:02 jkleinlercher