k8sgpt-operator icon indicating copy to clipboard operation
k8sgpt-operator copied to clipboard

[Feature]: add interval on ai backend request

Open JuHyung-Son opened this issue 10 months ago • 7 comments

Checklist

  • [X] I've searched for similar issues and couldn't find anything matching
  • [X] I've discussed this feature request in the K8sGPT Slack and got positive feedback

Is this feature request related to a problem?

No

Problem Description

No response

Solution Description

add ai backend request interval. if set, Sends requests to the AI backend server at set intervals, independent of the reconciler loop. this interval should be equal or higher than reconciliation's requeue interval.

Benefits

More control over ai backend requests.

Potential Drawbacks

No response

Additional Information

No response

JuHyung-Son avatar Apr 10 '24 14:04 JuHyung-Son

@JuHyung-Son I think we should move this to the operator's repo, right ?

arbreezy avatar Apr 19 '24 21:04 arbreezy

oh right i will move this

JuHyung-Son avatar Apr 20 '24 10:04 JuHyung-Son

@VaibhavMalik4187 would you like to assign it to you ?

arbreezy avatar Apr 21 '24 19:04 arbreezy

@VaibhavMalik4187 would you like to assign it to you ?

Yes please

VaibhavMalik4187 avatar Apr 21 '24 19:04 VaibhavMalik4187

@arbreezy, @JuHyung-Son, I've been working on this issue but I have a few questions.

  1. Why not just adjust the existing reconcile interval based on the interval value received from the user?
  2. Is there any specific reason behind keeping the interval equal to or longer than the existing reconcile interval?

VaibhavMalik4187 avatar Apr 23 '24 10:04 VaibhavMalik4187

good questions!

  1. Because reconcile does lots of things. like create new deployments, read k8sgpt crd, k8sgpt analyze ... and we want to add llm backend request interval. so it should be seperated. it will make problem if reconcile interval is 1 hour.
  2. llm request should be called after reconciler execute k8sgpt analyze.

JuHyung-Son avatar Apr 24 '24 07:04 JuHyung-Son

good questions!

1. Because reconcile does lots of things. like create new deployments, read k8sgpt crd, k8sgpt analyze ... and we want to add llm backend request interval. so it should be seperated. it will make problem if reconcile interval is 1 hour.

2. llm request should be called after reconciler execute k8sgpt analyze.

Understood, thanks for the detailed answers.

VaibhavMalik4187 avatar Apr 25 '24 03:04 VaibhavMalik4187