SpaceCadetPinball icon indicating copy to clipboard operation
SpaceCadetPinball copied to clipboard

Game allows entering high score when cheat was enabled during previous game

Open Takiro opened this issue 11 months ago • 0 comments

So I was playing around with the cheats and normally high scores are disabled when a cheat was used during a game. But I noticed at some point it still let me enter one. So I did some testing and this is how you can use some cheats (the ones you can toggle) and still have a high score dialog when game over.

  1. start program
  2. press New Game
  3. activate a cheat you can toggle (like hidden test or easy mode)
  4. press New Game again
  5. play with cheats and loose when having a high score

Expected result: Games shows high score on game board but dialogue does not open.

Actual result: game shows high score dialogue and lets you enter a name like in normal game

First I suspected it to be a mistake when when switching from demo mode to a new game when the cheat was activated in demo mode but while writing this I dug deeper and actually found this was even mentioned as an oddity in the code

	// Some of the control cheats persist across games.
	// Was this loose anti-cheat by design?
	CheatsUsed = 0;

I think it would be better to recheck if cheats are active when a new game starts and set CheatsUsed accordingly, what do you think?

Takiro avatar Nov 23 '24 10:11 Takiro