redmine_milestones icon indicating copy to clipboard operation
redmine_milestones copied to clipboard

Gantt crashes - 500

Open jpoa opened this issue 10 years ago • 0 comments

Salut!

Thanks for the work mister!

Just a small thing, Gantt generation is crashing on Redmine 2.4.2 (ubuntu packaged version) due to the missing sort method used on lib/milestones/gantt_patch.rb.

I fixed the issue by replacing the "sort_issues!(issues)" with "issues.sort!". Note that I only called the sort method on issues after the "if issues" to prevent some nil getting by.

My Ruby is really not good enough for these things, so Im urging anybody more able to have a look at the code please.

I know this is retarded and I could have made a pull, but for such a tiny amount of code I think its acceptable to add images :)

Anyway, the fix was just repeated on the three occurrences of the sort_issues!(issues) in the file.

Can any one comment on this please?

Cheers! retardedpullrequest

jpoa avatar Nov 24 '14 11:11 jpoa