kine
kine copied to clipboard
k3s-io
Driver for Sqlserver
Initial changes for a sqlserver driver.
Had to make some changes to generic driver to allow base queries to be injected into the generic driver due to way queries need TOP and not LIMIT need to be applied to queries.
Also needed to change how limit filter is applied in queries, and had to convert to a separate function to manipulate the query string.
I'd love to merge this (assuming it's reviewed and working) but under a build flag you'd have to opt into. The issue atm is that each new driver we add then adds a new go dependency to k3s. It would be good to change kine such project that depend on k3s can choose which drivers to import.
What's the status on this? I would like to really see this work. If there is anything I could do to help get this rolling again let me know. @ibrokethecloud happy to pick this up if you have moved on.
@phillipsj i am happy to help move it along. I wasn't sure if we wanted to progress this further.
@ibrokethecloud @phillipsj I would also like to see this to be implemented. One important thing to notice however is that after this PR was created #81 added e2e tests to here so it should be included to this together with rebase for code. This Docker image with Express edition can be used on those.
Then when it comes to TOP 100 PERCENT in query. I have been working with MS SQL DBs a lot and and newer seen TOP 100 PERCENT used and actually whole query look quite complex so would be nice to get copy of example database which explanation that what that query actually should return? I sure that there is better way to do it.
I am not sure. I have not seen much interest in this either. I am happy to close this for now.