k3s icon indicating copy to clipboard operation
k3s copied to clipboard

Update klipper-lb image version

Open manuelbuil opened this issue 2 years ago • 7 comments

Proposed Changes

Update klipper-lb image version to v0.4.6

Types of Changes

Version bump

Verification

Verify that klipper-lb image works by deploying a service of type external

Testing

Linked Issues

https://github.com/k3s-io/k3s/issues/9487

User-Facing Change


Further Comments

manuelbuil avatar Feb 14 '24 08:02 manuelbuil

Appears there may be something wrong with the new image:

  svclb-traefik-4fadc231-4f5fh
  Expected
      <string>: CrashLoopBackOff
  to equal
      <string>: Running

It works OK for me locally, but is consistently failing the e2e tests; I'm not sure why.

brandond avatar Feb 14 '24 17:02 brandond

Appears there may be something wrong with the new image:

  svclb-traefik-4fadc231-4f5fh
  Expected
      <string>: CrashLoopBackOff
  to equal
      <string>: Running

It works OK for me locally, but is consistently failing the e2e tests; I'm not sure why.

I'll investigate when I finish the multus integration

manuelbuil avatar Feb 15 '24 09:02 manuelbuil

Error identified and valid. Great work CI! It can't find iptables in OS using iptables-legacy as default (e.g. what CI uses, Ubuntu 20). Probably the reason is that Alpine 3.19 switched to iptables-nft by default. Need more investigation

manuelbuil avatar Feb 20 '24 18:02 manuelbuil

I suspect we need to add iptables-legacy to https://github.com/k3s-io/klipper-lb/blob/master/package/Dockerfile#L5

brandond avatar Feb 20 '24 19:02 brandond

I suspect we need to add iptables-legacy to https://github.com/k3s-io/klipper-lb/blob/master/package/Dockerfile#L5

Yes, that''s probably the best solution. x-tables-legacy-multi does not exist in 3.19 (after installing iptables), that's why it fails. The entry script requires it. I'm going to create a PR and once merged, I'll create v0.4.7 and declare v0.4.6 broken

manuelbuil avatar Feb 21 '24 10:02 manuelbuil

https://github.com/k3s-io/klipper-lb/pull/64

manuelbuil avatar Feb 21 '24 10:02 manuelbuil

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.86%. Comparing base (de82584) to head (adbc643). Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9488      +/-   ##
==========================================
- Coverage   49.42%   42.86%   -6.57%     
==========================================
  Files         151      154       +3     
  Lines       13475    13523      +48     
==========================================
- Hits         6660     5796     -864     
- Misses       5474     6559    +1085     
+ Partials     1341     1168     -173     
Flag Coverage Δ
e2etests ?
inttests 39.42% <ø> (-0.04%) :arrow_down:
unittests 15.96% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 23 '24 07:02 codecov[bot]