k3s icon indicating copy to clipboard operation
k3s copied to clipboard

Published 20 hours ago • verified publisher icon k3s-io

[Epic] Add Integration Test for all server/agent flags

Open rancher-max opened this issue 2 years ago • 6 comments

Similar to https://github.com/k3s-io/k3s/issues/6056, but this is for a single test that uses ALL (or the most possible) configuration flags.

EDIT 04/11/23 Integration Server Flags Testing Status

Server flags:
  • - [x] disable
  • - [x] disable-network-policy
  • - [x] with-node-id
  • - [x] write-kubeconfig-mode
  • - [x] flannel-external-ip
  • - [x] selinux
  • - [x] cluster-init
  • - [x] disable-scheduler
  • - [x] node-taint
  • - [x] data-dir
  • - [x] token
  • - [x] server
  • - [x] node-label
  • - [x] cluster-cidr
  • - [x] node-name
  • - [x] flannel-ipv6-masq
  • - [x] node-ip
  • - [x] kubelet-arg
  • - [x] bind-address
  • - [x] snapshotter
  • - [x] secrets-encryption
  • - [x] node-external-ip
  • - [x] disable-helm-controller
  • - [x] flannel-iface
  • - [x] service-cidr
  • - [x] multi-cluster-cidr
  • - [x] tls-san
  • - [x] flannel-backend
  • - [x] etcd-arg
  • - [x] prefer-bundled-bin
  • - [ ] debug
  • - [x] kube-proxy-arg
  • - [x] kube-controller-manager-arg
  • - [ ] write-kubeconfig
  • - [x] etcd-snapshot-retention
  • - [ ] log
  • - [ ] agent-token-file
  • - [x] kube-apiserver-arg
  • - [ ] disable-cloud-controller
  • - [ ] resolv-conf
  • - [ ] etcd-expose-metrics
  • - [ ] lb-server-port
  • - [ ] https-listen-port
  • - [ ] advertise-port
  • - [ ] cluster-dns
  • - [x] etcd-snapshot-name
  • - [ ] default-local-storage-path
  • - [ ] vmodule
  • - [x] kube-scheduler-arg
  • - [x] kube-cloud-controller-manager-arg
  • - [ ] token-file
  • - [x] etcd-disable-snapshots
  • - [x] etcd-snapshot-schedule-cron
  • - [x] etcd-snapshot-dir
  • - [ ] disable-kube-proxy
  • - [ ] advertise-address
  • - [ ] agent-token
  • - [ ] datastore-cafile
  • - [x] etcd-snapshot-compress
  • - [ ] alsologtostderr
  • - [ ] servicelb-namespace
  • - [ ] egress-selector-mode
  • - [ ] config
  • - [ ] protect-kernel-defaults
  • - [ ] enable-pprof
  • - [ ] service-node-port-range
  • - [ ] cluster-reset-restore-path

The following flags are unsuited for Integration test

Not For Integration Test
:x: system-default-registry :x: cluster-domain :x: etcd-s3-folder
:x: private-registry :x: etcd-s3-region :x: etcd-s3
:x: datastore-endpoint :x: image-credential-provider-bin-dir :x: docker
:x: datastore-certfile :x: etcd-s3-secret-key :x: pause-image
:x: etcd-s3-access-key :x: flannel-cni-conf :x: rootless
:x: datastore-keyfile :x: etcd-s3-insecure :x: etcd-s3-skip-ssl-verify
:x: container-runtime-endpoint :x: image-credential-provider-config :x: etcd-s3-endpoint
:x: etcd-s3-endpoint-ca :x: etcd-s3-bucket :x: etcd-s3-timeout
:x: flannel-conf :x: cluster-reset

rancher-max avatar Aug 30 '22 16:08 rancher-max

@rancher-max is this still in progress?

caroline-suse-rancher avatar Nov 08 '22 16:11 caroline-suse-rancher

Yes I don't think any of us have picked it up to start working yet.

rancher-max avatar Nov 08 '22 17:11 rancher-max

I'll move milestones then, thank you!

caroline-suse-rancher avatar Nov 08 '22 17:11 caroline-suse-rancher

@osodracnai Hey! Are you still working on this? The last linked PR I see is from May. Thanks!

caroline-suse-rancher avatar Jul 10 '23 16:07 caroline-suse-rancher

@caroline-suse-rancher Yeah, but not only focused on it. If you want i can make it my priority.

osodracnai avatar Jul 10 '23 16:07 osodracnai

@osodracnai No, no worries! Just asking for a status update, that sounds good :)

caroline-suse-rancher avatar Jul 10 '23 16:07 caroline-suse-rancher

Closing this as complete, all easily testable flags via integration test have been covered.

dereknola avatar Mar 07 '24 23:03 dereknola