k3s-ansible icon indicating copy to clipboard operation
k3s-ansible copied to clipboard

Published 20 hours ago • verified publisher icon k3s-io

Add support raspbian bullseye

Open husjon opened this issue 2 years ago • 3 comments

This PR adds support for raspbian bullseye. It has been tested on newly flashed pi3b+ nodes (combination of buster and bullseye) with only SSH enabled. (I do currently not have pi4 nodes in my possession)

Test run output: https://gist.github.com/husjon/00965e50afffd8865e8ac3db66edb30f

What's been changed:

  • Added check for Raspbian Bullseye
  • Added task switch for Raspbian distribution codenames
  • Removed requirement for iptables on Rasbpian Bullseye (this is because bullseye comes with nftables preinstalled)
  • Removed 'cgroup_enable=cpuset' for bullseye. On bullseye using Pi3B+ this seem to bring the server to its knees, seeing average loads up to 15 while agents are added. This makes it so that the agents are unable to communicate with the server. (screenshot in comments)

husjon avatar Apr 09 '22 13:04 husjon

Here's a screenshot of the load from the server while adding agents. I was lucky to have the SSH connection open during this, the connection is barely working and htop is updating only every now and then.

image

husjon avatar Apr 09 '22 17:04 husjon

Nice work! I would have solved it in nearly the same way. However, adding the codename (which is a one to one map of major version) is redundant imo, and I would suggest we use only one of major version and codename.

JohanNicander avatar May 08 '22 14:05 JohanNicander

Thanks for the feedback, I don't mind either solution, I just found it easier to read the codenames rather than version numbers for the task filenames. :) I do however realize that major_release is used in the prior task setting the facts raspberrypi/tasks/main.yml#L36-L40, so might as well continue this trend.

I'll prepare a commit with the necessary changes.

husjon avatar May 08 '22 16:05 husjon

@ozgurgul and @JohanNicander, is there a reason this fix is approved but hasn't been merged?

kraihn avatar Jan 04 '23 19:01 kraihn

@ozgurgul and @JohanNicander, is there a reason this fix is approved but hasn't been merged?

I had to implement this fix the other day setting up a new Raspberry Pi cluster with Raspberry Pi OS, so I'm wondering the same thing. This seems like a simple fix that should be merged with little issue.

KI7ODK avatar Jan 29 '23 20:01 KI7ODK

@ozgurgul and @JohanNicander, is there a reason this fix is approved but hasn't been merged?

I had to implement this fix the other day setting up a new Raspberry Pi cluster with Raspberry Pi OS, so I'm wondering the same thing. This seems like a simple fix that should be merged with little issue.

I'm not a contributor to this repo. Hence I can't merge this PR but otherwise I share the same thoughts.

ozgurgul avatar Jan 30 '23 02:01 ozgurgul

Hi @St0rmingBr4in what is required for this PR to be merged? Thanks in advance

husjon avatar Jan 30 '23 21:01 husjon

Please can this PR get merged sooner rather than later. Thanks.

berkobob avatar Apr 06 '23 11:04 berkobob

This is really helpful! Huge thanks to @husjon

ericyangchen avatar Apr 19 '23 15:04 ericyangchen

tested this on my raspberry pi cm4 cluster and totally works 👍

akrami avatar Jul 14 '23 06:07 akrami

I'm SO tempted to use this. I tried to spin up my cluster with an aarch64 OS instead of armv7 and it didn't really work out for me, but it seems that this would solve my issue completely.

I say this PR should be merged!

nullset2 avatar Aug 03 '23 20:08 nullset2

Closing in favor of changes in https://github.com/k3s-io/k3s-ansible/pull/151

dereknola avatar Nov 07 '23 18:11 dereknola