cluster-api-k3s icon indicating copy to clipboard operation
cluster-api-k3s copied to clipboard

Published 20 hours ago • verified publisher icon k3s-io

v1beta2 changes

Open richardcase opened this issue 1 year ago • 5 comments

This issue is to track API changes that the project wants to make as part of an API bump from v1beta1 to v1beta2.

  • [ ] Introduce a KThreesControlPlaneMachineTemplate kind that will contain the existing InfrastructureRef & NodeDrainTimeout and will additionally introduce ObjectMeta (which will require a converstion from the change done in #59 )

richardcase avatar Oct 12 '23 09:10 richardcase

Thanks @richardcase. We should probably also do an audit of k3s flags that are missing and make sure v1beta2 considers them in its design.

zawachte avatar Oct 12 '23 13:10 zawachte

Sounds good to me.

I'll also check what we have added to the RKE2 provider to see if there is anything we add here as well.

richardcase avatar Oct 12 '23 16:10 richardcase

I think https://github.com/cluster-api-provider-k3s/cluster-api-k3s/issues/63 is part of the consideration for this version change (just linking them together).

philjb avatar Oct 17 '23 15:10 philjb

link https://github.com/cluster-api-provider-k3s/cluster-api-k3s/issues/73

Need add machineSpec properties nodeDeletionTimeout in KThreesControlPlaneMachineTemplate

Better add nodeVolumeDetachTimeout as well in case we need it in future.

mogliang avatar Nov 21 '23 03:11 mogliang

link #73

Need add machineSpec properties nodeDeletionTimeout in KThreesControlPlaneMachineTemplate

Better add nodeVolumeDetachTimeout as well in case we need it in future.

Seems that we do not have these fields yet, should we also add them?

nasusoba avatar May 16 '24 04:05 nasusoba