uptime-kuma-helm icon indicating copy to clipboard operation
uptime-kuma-helm copied to clipboard

feat: allow service monitor without authentication or with auth data from existing secret

Open maxnitze opened this issue 1 year ago • 2 comments

Allow to disable authentication of the service monitor by settings .Values.serviceAccount.authentication.enabled=false. Also allow to provide an existing secret for the service monitor authentication.

maxnitze avatar Aug 08 '24 14:08 maxnitze

Hey, sorry for the late response, been rather busy IRL lately and haven't had the time nor motivation to really give this project the attention it deserves. I will see to review both of your PRs tomorrow.

k3rnelpan1c-dev avatar Sep 02 '24 22:09 k3rnelpan1c-dev

Hey! I answered your comment. I can switch it, of course. Makes more sense to me as well. Your call :)

maxnitze avatar Sep 18 '24 16:09 maxnitze

Thank you for your contribution!

k3rnelpan1c-dev avatar Jan 01 '25 21:01 k3rnelpan1c-dev