APhotoManager icon indicating copy to clipboard operation
APhotoManager copied to clipboard

Filter-view: logical "OR" for tags: find "... where tag=tag1 or tag=tag2 or ...." ?

Open xandro0777 opened this issue 6 years ago • 2 comments

perhaps if "," inbetween tags in the text fields means AND then " " could be used for OR, such as {{{peter,harbor,night peter,crete}}} would filter pictures with either (peter AND harbor and NIGHT) or (peter AND crete) ?

xandro0777 avatar Mar 13 '19 22:03 xandro0777

a good idea but i donot want to change the semantic from

  • currently " " means "and" to
  • " " means "or" which destroys the saved filteres

maybe sorounding with "(..)" changes from "and" to "or". not intuiltive but backwards compatible. any idea how to make it more intuitive?

As a workaround for you can create the filter with "and", save as album file and edit the album file with a texteditor and replace the text with "or"


if somebody wants to implement this

it should be doable without knowing how the whole app works.

just start with unit tests in

  • de.k3b.android.androFotoFinder.tagDB.TagSqlQueryParserTests for the sql part and
  • de.k3b.io.GalleryFilterParameterTest for (de-)serialisation

k3b avatar Mar 14 '19 07:03 k3b

If the space char is already taken, could "||" work?

xandro0777 avatar Mar 15 '19 22:03 xandro0777