ViChrome icon indicating copy to clipboard operation
ViChrome copied to clipboard

Works in chrome54

Open mgi166 opened this issue 9 years ago • 3 comments

Fix the issue https://github.com/k2nr/ViChrome/issues/67. This PR works in Chrome 54 for now.

Summary

  • KeyboardEvent.keyIdentifier is deprecated in Chrome M54. Use KeyboardEvent.key instead.
  • KeyboardEvent.key returns the charcator you entered. so remove the keycode maps and fix some logics.
  • For compatibility of settings in mac, aliases special characters with option key to original key.
    • https://github.com/mgi166/ViChrome/commit/99edaf643105cc88e306b2ed08fd4365c9eb17d3
  • There is still a useless implementation, but I made only minimal modifications.

mgi166 avatar Nov 12 '16 13:11 mgi166

@mgi166 Works well in chrome 54(except binding Space in nmap) but unfortunately not working properly in chrome 55. Vichrome works only after refreshing page and searching in history or bookmarks doesn't show hints, tablist is also not working. :-(
Anyway, thanks for fixing this for 54.

citypops avatar Dec 07 '16 10:12 citypops

@citypops I'm sorry. too late response.

Works well in chrome 54(except binding Space in nmap)

Oh, I don't notify this behavior. But I don't understand the reason that is not working binding with space. Please give me some time.

but unfortunately not working properly in chrome 55.

I use chrome 55, but I wasn't able to replicate this bug. Using macOS Sierra, it's replicated.

I will resource this problem.

mgi166 avatar Jan 11 '17 12:01 mgi166

Using macOS Sierra, it's replicated.

Sorry, I mistake simply. Change branch work-in-chrome54 and works chrome 55 in macOS Sierra.

mgi166 avatar Jan 21 '17 04:01 mgi166