snowfall icon indicating copy to clipboard operation
snowfall copied to clipboard

To be more Pythonic

Open csukuangfj opened this issue 4 years ago • 2 comments

There exist shell scripts and Perl scripts for data preparation, most of which are modified from Kaldi. They provide extra functionalities that are actually not needed in snowfall.

I would suggest doing as many things as possible in Python and getting rid of shell scripts and Perl scripts as best as we can.

csukuangfj avatar Dec 18 '20 07:12 csukuangfj

Sure, but bear in mind that the whole idea of Snowfall (vs. Icefall) is "move fast and break things". At this point our main goal is to get a prototype working and debug k2 and lhotse, so while eventually we'll want to do things more Pythonically, let's not prioritize it too highly.

danpovey avatar Dec 18 '20 08:12 danpovey

+1 to what both of you are saying. These scripts are also on my radar, but I'm refraining myself from touching that as I'd prefer to contribute to a working recipe first :)

pzelasko avatar Dec 18 '20 14:12 pzelasko