sherpa icon indicating copy to clipboard operation
sherpa copied to clipboard

RTF for cpu

Open lalimili6 opened this issue 2 years ago • 10 comments

Hi dear, can report RTF for cpu? best regards

lalimili6 avatar Jul 22 '22 06:07 lalimili6

https://github.com/k2-fsa/sherpa#rtf-test

Screen Shot 2022-07-22 at 2 06 08 PM

Can you use the above colab notebook to measure RTF for CPU. (The default is using GPU).

A PR is welcome if you can do that.

Thanks

csukuangfj avatar Jul 22 '22 06:07 csukuangfj

@csukuangfj Actually I was about to create an issue to tackle it (to also have an RTF for streaming model, etc) :)

ezerhouni avatar Jul 22 '22 07:07 ezerhouni

@csukuangfj Actually I was about to create an issue to tackle it (to also have an RTF for streaming model, etc) :)

That would be very nice of you. If @lalimili6 does not respond, I suggest that you can just start it.

csukuangfj avatar Jul 22 '22 07:07 csukuangfj

@csukuangfj Actually I was about to create an issue to tackle it (to also have an RTF for streaming model, etc) :)

That would be very nice of you. If @lalimili6 does not respond, I suggest that you can just start it.

I will work first on the refactoring of the beam search, if time allows I will give a look to RTF

ezerhouni avatar Jul 22 '22 07:07 ezerhouni

Thanks!

csukuangfj avatar Jul 22 '22 07:07 csukuangfj

@csukuangfj Also, I was thinking to maybe add the RTF in Results.md in icefall, to give a sense of how much CPU/GPU usage it needs (so not only comparing WER but also RTF), wdyt ?

ezerhouni avatar Jul 22 '22 08:07 ezerhouni

@csukuangfj Also, I was thinking to maybe add the RTF in Results.md in icefall, to give a sense of how much CPU/GPU usage it needs (so not only comparing WER but also RTF), wdyt ?

Yes, that is a good idea. I also suggest adding the number of parameters of the model to RESULTS.md.

Since RTF depends on what hardware you are using, shall we also list the environment in which RTF is measured?

csukuangfj avatar Jul 22 '22 08:07 csukuangfj

I also suggest adding the number of parameters of the model to RESULTS.md.

Agree !

Since RTF depends on what hardware you are using, shall we also list the environment in which RTF is measured?

Yes, testing for both CPU and GPU, with description of hardware + software (cuda, cudnn, etc).

ezerhouni avatar Jul 22 '22 08:07 ezerhouni

@csukuangfj I tried to add the RTF for the streaming pipeline. However, I keep having sent 1011 (unexpected error) keepalive ping timeout; no close frame received any idea why ? (I can create a PR for you to have a look into the code if you want)

ezerhouni avatar Aug 19 '22 13:08 ezerhouni

@csukuangfj I tried to add the RTF for the streaming pipeline. However, I keep having sent 1011 (unexpected error) keepalive ping timeout; no close frame received any idea why ? (I can create a PR for you to have a look into the code if you want)

Thanks for testing it.

I think it is the same error reported in https://github.com/k2-fsa/sherpa/issues/84

I will look into it during the weekend.

csukuangfj avatar Aug 19 '22 15:08 csukuangfj

Here are results https://github.com/k2-fsa/sherpa/pull/168 many thanks

lalimili6 avatar Oct 23 '22 13:10 lalimili6