sherpa-onnx icon indicating copy to clipboard operation
sherpa-onnx copied to clipboard

Add to F-Droid

Open Dmole opened this issue 1 year ago • 14 comments

https://f-droid.org/contribute/

Dmole avatar Jan 10 '24 00:01 Dmole

Are you going to contribute to add it?

csukuangfj avatar Jan 10 '24 01:01 csukuangfj

I'll help if I can,

Step one is obtaining your (original app author) approval. Step two is having you (someone familiar with the app) give the Inclusion Policy a quick read to see if any of the 12+ points are show stoppers.

Or if there is a conflict ( like https://github.com/edeso/bubble2 wanting to use unrar-nonfree vs unrar-free) the app can be added via an alternative repository (vs the main repository).

Dmole avatar Jan 10 '24 21:01 Dmole

give the Inclusion Policy a quick read to see if any of the 12+ points are show stoppers.

Could you tell us where we can find the above 12+ points?

csukuangfj avatar Jan 13 '24 07:01 csukuangfj

From the link in the first post;

Submit Applications

If you see an application missing from the repository (after reading the inclusion policy ...

Dmole avatar Jan 13 '24 10:01 Dmole

Step one is obtaining your (original app author) approval.

We are very glad if you can contribute to add it to F-Droid as long as you state that the app is from this repo.

Step two is having you (someone familiar with the app) give the Inclusion Policy a quick read to see if any of the 12+ points are show stoppers.

I have just gone through all the items and I think we are not violating any of them.

csukuangfj avatar Jan 13 '24 11:01 csukuangfj

https://gitlab.com/fdroid/rfp/-/issues/2629

Dmole avatar Jan 14 '24 03:01 Dmole

https://gitlab.com/fdroid/rfp/-/issues/2629

Thank you!

csukuangfj avatar Jan 14 '24 03:01 csukuangfj

This would be more difficult than a normal app, since each language and each voice are included on the apk package. It should be done as for AnySoftKeyboard for example. I have done the fastlane data for one app, but this probably would be more difficult. Also the icon should be improved, anyone know if there is a svg of the logo?

paolo-caroni avatar Feb 07 '24 17:02 paolo-caroni

For the logo, please have a look at https://k2-fsa.github.io/k2/_images/logo.png

csukuangfj avatar Feb 08 '24 11:02 csukuangfj

since each language and each voice are included on the apk package.

The major issue is that we don't know how to download model files in Android.

If you can help, a better design is to download models for a certain language requested by the user.

csukuangfj avatar Feb 08 '24 11:02 csukuangfj

For the logo, please have a look at https://k2-fsa.github.io/k2/_images/logo.png

Ok, is still a png, but I can work on it, you are sure that is the correct one? on the official page I have found the other logo.

Also, about helping on improve the download capability, I'm sorry, I can do only hint of other open-source project that already did it. I can help only on fastlane and logo. Fastlane is very impiortant for F-Droid, since thank to it is all automatic wen the app is added for the first time, the F-Droid server search if there is a new release (that should be tagged on github) and then create the new apk automatically.

paolo-caroni avatar Feb 08 '24 11:02 paolo-caroni

on the official page I have found the other logo.

Sorry that I did not notice this page before.


next-gen-kaldi-logo.pdf

Please find all of the logos of next-gen kaldi in the above pdf, including the one for Sherpa. (This is the first time we make the logo of Sherpa available to the public)

csukuangfj avatar Feb 08 '24 12:02 csukuangfj

Thanks, the logo seems to be too detailed in my honest opinion. Don't misunderstood, is beautiful, but will be difficult make it an adaptive icon. In the next weeks I will do my best and then ask a pr, but please dont expect too much, especially on the monochrome icon(maybe if looks to ugly I will drop it).

paolo-caroni avatar Feb 08 '24 17:02 paolo-caroni

Thanks for this great work! If publishing to f-droid.org isn't feasible right now, maybe you could set up your own repo in the meantime? This would result in automatic updates. I hope it's just a simple http server https://f-droid.org/docs/Setup_an_F-Droid_App_Repo/ Someone even automated it with github actions https://github.com/xarantolus/fdroid/blob/main/setup.md

gabmert avatar Aug 23 '24 21:08 gabmert