icefall icon indicating copy to clipboard operation
icefall copied to clipboard

Published 20 hours ago • verified publisher icon k2-fsa

Context graph

Open ezerhouni opened this issue 3 years ago • 6 comments

I was wondering if there is any plan on adding context graph to k2/Icefall (something similar to :https://wenet.org.cn/wenet/context.html )

cc @csukuangfj

ezerhouni avatar Nov 01 '22 13:11 ezerhouni

Yes, it is one of our plans and we‘ve made initial progress on this.

marcoyang1998 avatar Nov 01 '22 13:11 marcoyang1998

@marcoyang1998 Thanks ! Do you need a hand ? I started working also on it

ezerhouni avatar Nov 01 '22 13:11 ezerhouni

@ezerhouni

could you have a look at https://github.com/k2-fsa/icefall/pull/645 and help propagate the changes to other folders in librispeech?

csukuangfj avatar Nov 02 '22 10:11 csukuangfj

@csukuangfj Let me have a look. I can start doing the propagation tomorrow. In the coming days I will open a PR for context graph, and if you have time to have a look it would be great

ezerhouni avatar Nov 02 '22 10:11 ezerhouni

@csukuangfj Let me have a look. I can start doing the propagation tomorrow.

In the coming days I will open a PR for context graph, and if you have time to have a look it would be great

Sure, thanks!

csukuangfj avatar Nov 02 '22 11:11 csukuangfj

@csukuangfj Also, in the last implementation modified_beam_search_ngram_rescoring, I might have found an error

ezerhouni avatar Nov 02 '22 14:11 ezerhouni