icefall icon indicating copy to clipboard operation
icefall copied to clipboard

[NOT FOR MERGE] Add Blank Skip to Zipformer2

Open ezerhouni opened this issue 2 years ago • 5 comments

I will double check that I am not missing something.

cc @csukuangfj

ezerhouni avatar Aug 17 '23 07:08 ezerhouni

Thanks!

yfyeung avatar Aug 18 '23 01:08 yfyeung

@csukuangfj @danpovey If merging this PR is not very urgent and useful (>2 weeks), I can run it librispeech with all the changes needed (from review this PR) update Results.md

ezerhouni avatar Aug 28 '23 05:08 ezerhouni

We also need to see whether this might cause a problem for streaming systems, e.g. does it support streaming_forward().

danpovey avatar Aug 28 '23 06:08 danpovey

@csukuangfj @danpovey If merging this PR is not very urgent and useful (>2 weeks), I can run it librispeech with all the changes needed (from review this PR) update Results.md

That would be great. We have not used blank skipping with the latest zipformer.

csukuangfj avatar Aug 28 '23 06:08 csukuangfj

@danpovey It should work with streaming_forward @csukuangfj I will try to schedule that asap. In the meantime, any review would be welcome (so that I can test the reviewed code)

Thank you

ezerhouni avatar Aug 28 '23 06:08 ezerhouni