awspec icon indicating copy to clipboard operation
awspec copied to clipboard

#443: SSM Parameters pagination issue, replaced with get_parameter AP…

Open cthulhu opened this issue 5 years ago • 4 comments

Replaced ssm parameters describe API call with get_parameter call to fix pagination issue.

Fixed specs and changed a bit behavior of the spec for ssm. It has a few values less now because of the differences in APIs. However, it also has value now. So we can test against it if it is not encrypted.

cthulhu avatar Aug 06 '19 05:08 cthulhu

Hi @cthulhu . Thank you for your pull request !!! According to the documentation, describe_parameters seems to be able to get all parameters using next_token .

k1LoW avatar Aug 17 '19 11:08 k1LoW

@k1LoW Indeed, however, the code would become a bit more complex if you would iterate over the params. Besides, API has an endpoint to fetch 1 param info. Perhaps we could go with that? Otherwise, I can change it but it will take some time.

cthulhu avatar Aug 21 '19 06:08 cthulhu

@cthulhu

I care about the difference in interface.

It has a few values less now because of the differences in APIs

Otherwise, I can change it but it will take some time.

Thank you !

k1LoW avatar Aug 22 '19 05:08 k1LoW

@k1LoW @cthulhu create a new PR (https://github.com/k1LoW/awspec/pull/583) that uses pagination

anjo-swe avatar Dec 20 '23 22:12 anjo-swe