k0s icon indicating copy to clipboard operation
k0s copied to clipboard

Add config option to set bind address for all components.

Open jnummelin opened this issue 2 years ago • 4 comments

This enables to bind all components, that listen for traffic, only to certain interface on the host.

Draft as we're waiting for reactions on https://github.com/kubernetes-sigs/apiserver-network-proxy/pull/363 In the meantime konnectivity is build from my custom branch which has the bind-address flags.

Signed-off-by: Jussi Nummelin [email protected]

Description

Fixes #1150 , the ability to use VIP+LB on controller nodes.

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation update

How Has This Been Tested?

  • [ ] Manual test
  • [x] Auto test added

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] My commit messages are signed-off
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [ ] I have checked my code and corrected any misspellings

jnummelin avatar Jun 22 '22 22:06 jnummelin

check-tunneledkas smoke test failing as my custom branch for konnectivity bind-address does not have the tunneling built in

jnummelin avatar Jun 23 '22 09:06 jnummelin

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Jul 23 '22 23:07 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Sep 09 '22 23:09 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Oct 10 '22 23:10 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Nov 11 '22 23:11 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Dec 12 '22 23:12 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Jan 13 '23 23:01 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Feb 13 '23 23:02 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Mar 16 '23 23:03 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Apr 16 '23 23:04 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar May 18 '23 23:05 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Jun 19 '23 23:06 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Jul 20 '23 23:07 github-actions[bot]

@jnummelin hi! what's the status of this PR? The linked PR has been merged and released and appears to be present in the currently used version of konnectivity.

michaelbeaumont avatar Jul 22 '23 20:07 michaelbeaumont

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Aug 21 '23 23:08 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Sep 21 '23 23:09 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Oct 23 '23 23:10 github-actions[bot]

@jnummelin are we planning to merge this?

sudas-px avatar Nov 01 '23 15:11 sudas-px

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Dec 01 '23 23:12 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Jan 01 '24 23:01 github-actions[bot]

This pull request has merge conflicts that need to be resolved.

github-actions[bot] avatar Jan 05 '24 12:01 github-actions[bot]

closing this in favor of the newer in-flight PR

jnummelin avatar Jan 11 '24 11:01 jnummelin

That PR being https://github.com/k0sproject/k0s/pull/3824 presumably

michaelbeaumont avatar Jan 11 '24 12:01 michaelbeaumont