k0s
k0s copied to clipboard
k0sproject
Kubelet Args vs. kubelet config file: which should be supported?
Currently we have two ways to configure kubelet on the node:
- Kubelet extra args, which are configured by running
k0s worker --kubelet-extra-args(example: --kubelet-extra-args='--event-qps=7 --enable-load-reader=true') - using a kubelet config file using a worker profile.
Currently we have precedence of the kubelet config from the cli flags, over the kubelet config file. Given the below quote from the Kubernetes' kubelet config doc:
Providing parameters via a config file is the recommended approach because it simplifies node deployment and configuration management.
I think we should graduate this behaviour (for consistency) and deprecate the kubelet-extra-args flag, provided that we can equate all kubelet flags to the kubelet config file values.
The issue is marked as stale since no activity has been recorded in 30 days
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
The issue is marked as stale since no activity has been recorded in 30 days
The issue is marked as stale since no activity has been recorded in 30 days
I think, having args makes life much easier with a fast experiments. While we still have way to customize kubelet.conf by using k0s.yaml worker profiles, sometimes for an experiment it is easier to just run k0s without config (read as with default config). But I think it would be better if we do not pass any args to kubelet by default by changing code here https://github.com/k0sproject/k0s/blob/main/pkg/component/worker/kubelet.go#L134 to use kubelet.conf instead.
The issue is marked as stale since no activity has been recorded in 30 days
The issue is marked as stale since no activity has been recorded in 30 days
The issue is marked as stale since no activity has been recorded in 30 days
The issue is marked as stale since no activity has been recorded in 30 days
The issue is marked as stale since no activity has been recorded in 30 days
The issue is marked as stale since no activity has been recorded in 30 days