missing pid file to openrc init

[arankaren]

https://github.com/k0sproject/k0s/blob/3fc8d7940d044849e6c9a0f656259167fa0d6b77/pkg/install/linux_openrc.go#L23

it's necessary add pid inside openrc init,

Please add pidfile=/var/run/k0s.pid:

...
description="{{.Description}}"
pidfile=/var/run/k0s.pid
...

[jnummelin]

it's necessary add pid inside openrc init

What issues you see when it's not there? (not saying we shouldn't add it 😄 )

[kke]

I think it should be /run/k0s.pid (altough /var/run likely is a symlink to /run on many systems)

[arankaren]

it's necessary add pid inside openrc init

What issues you see when it's not there? (not saying we shouldn't add it smile )

without the pid the daemon does not work on OS with OpenRC

[ncopa]

Which OS does it not work on? What is the error message or what happens when it does not work?

I am not convinced using the pid file is a good idea.

[kke]

OpenRC service script docs:

--

Looks to me like OpenRC really wants a pidfile

It can create one on its own though:

--

[github-actions[bot]]

The issue is marked as stale since no activity has been recorded in 30 days

[twz123]

without the pid the daemon does not work on OS with OpenRC

It works at least on Alpine. Can you provide more details, as requested in https://github.com/k0sproject/k0s/issues/1775#issuecomment-1160372664? Which OS does it not work on? What is the error message or what happens when it does not work?

[github-actions[bot]]

The issue is marked as stale since no activity has been recorded in 30 days