k0s icon indicating copy to clipboard operation
k0s copied to clipboard

Verify `NetworkManager-wait-online.service` or `systemd-networkd-wait-online.service` are enabled

Open e-minguez opened this issue 4 years ago • 6 comments

Is your feature request related to a problem? Please describe. Using Armbian, neither NetworkManager-wait-online.service nor systemd-networkd-wait-online.service, so even if the k0scontroller systemd unit has:

After=network-online.target 
Wants=network-online.target

It has no effect and the k0scontroller service fails to start. It works if manually perform a 'systemctl daemon-reload' and restart the k0scontroller service after the operating system completely boots.

Describe the solution you'd like Something that checks if NetworkManager or networkd is enabled, then check if the corresponding wait-online service is enabled and enable it otherwise.

Describe alternatives you've considered Check the service and warn the user but not enable it.

Additional context https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/

e-minguez avatar Oct 06 '21 14:10 e-minguez

Thanks for raising this issue. Do you mean the systemd-networkd-wait-online.service in Armbian is not enabled by default?

xinfengliu avatar Oct 11 '21 08:10 xinfengliu

Thanks for raising this issue. Do you mean the systemd-networkd-wait-online.service in Armbian is not enabled by default?

Correct.

e-minguez avatar Oct 11 '21 13:10 e-minguez

Not very clear about the your use cases/concerns, is it because it is difficult to enable that wait service in Armbian before provisioning k0s? After all, in most x64 linux distributions, the correspondent wait service is enabled by default and we don't worry about it.

xinfengliu avatar Oct 12 '21 04:10 xinfengliu

The point I'm trying to make is the k0scontroller service requieres the 'wait' service to be enabled hence the installer should either check it and warn the user if that's not the case or enable it.

e-minguez avatar Oct 12 '21 14:10 e-minguez

The issue is marked as stale since no activity has been recorded in 30 days

jnummelin avatar Dec 21 '21 23:12 jnummelin

The issue is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Jan 23 '22 23:01 github-actions[bot]