k0s
k0s copied to clipboard
k0sproject
Add spec.api.bindAddress configuration
Should a new bindAddress option be created and change documentation for the existing address option, or should the existing address option's behavior be changed to match the existing documentation?
The later I can see causing some issues with existing setups, bindAddress is probably the safest route. Currently the default for bindAddress is "0.0.0.0", which is the default kube-api-server uses if the --bind-address flag isn't used.
Issue Fixes #957
What this PR Includes
Adds the ability to define a bindAddress for the kube-api-server.
I'd prefer to use separate bindAddress option as more safe route for this
@jnummelin Is there anything more I need to do on this PR? I want to make sure I am not missing anything.
@gakio12 Just curious, are you still planning to work on this? I'd need this to make my setup work as well, so was simply wondering what your plans were to decide on whether to wait. (Among other things, this would then need an addition to k0sctl to allow setting the BindAddress per controller etc.)
@ocraviotto Yes, I am planning to commit the changes proposed in the next few weeks now that I have gained some free time (and got my environment back).
The PR is marked as stale since no activity has been recorded in 30 days
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
The PR is marked as stale since no activity has been recorded in 30 days
The PR is marked as stale since no activity has been recorded in 30 days
The PR is marked as stale since no activity has been recorded in 30 days
The PR is marked as stale since no activity has been recorded in 30 days
The PR is marked as stale since no activity has been recorded in 30 days
The PR is marked as stale since no activity has been recorded in 30 days
The PR is marked as stale since no activity has been recorded in 30 days
The PR is marked as stale since no activity has been recorded in 30 days
The PR is marked as stale since no activity has been recorded in 30 days
The PR is marked as stale since no activity has been recorded in 30 days
The PR is marked as stale since no activity has been recorded in 30 days
The PR is marked as stale since no activity has been recorded in 30 days
The PR is marked as stale since no activity has been recorded in 30 days
The PR is marked as stale since no activity has been recorded in 30 days
The PR is marked as stale since no activity has been recorded in 30 days
The PR is marked as stale since no activity has been recorded in 30 days
The PR is marked as stale since no activity has been recorded in 30 days
The PR is marked as stale since no activity has been recorded in 30 days
This pull request has merge conflicts that need to be resolved.