Project-Tauro icon indicating copy to clipboard operation
Project-Tauro copied to clipboard

Published 20 hours ago • verified publisher icon k0r0pt

Need test class for the class - FindHttpBasicAuthFinder.

Open sudiptosarkar opened this issue 6 years ago • 4 comments

Yes, I know the class name needs refactor. We need a test class made for this class. Tests should not make real calls. Instead, calls must be mocked with Mockito and/or PowerMockito. Examples of the testing pattern can be found in the other three dependency repos mentioned in the README.md.

sudiptosarkar avatar Oct 24 '17 18:10 sudiptosarkar

Hi !

I'd like to start working on this.

cyterdan avatar Oct 26 '17 17:10 cyterdan

@cyterdan Sure... Go ahead. Raise a Pull Request when you're done and put me on review... 🙂

sudiptosarkar avatar Oct 26 '17 17:10 sudiptosarkar

Seems there is an infinite loop when google is not reachable, is that by design ?

cyterdan avatar Oct 26 '17 21:10 cyterdan

@cyterdan Yes. That's for resiliency. If the attacking system's Internet goes down, it will wait till it's back up... Also because my Internet connection sucked when I wrote it... :smiley:

sudiptosarkar avatar Oct 27 '17 03:10 sudiptosarkar