Hugo Tunius

icon indicating a website link http://hugotunius.se icon indicating an email [email protected]

icon company Lookback icon location Edinburgh, Scotland icon location I write code in many languages. Interested in low level performance, UX/UI, API design, testing, ray tracing, @danger, @CocoaPods, Swift, Rust, and more

Results 217 comments of Hugo Tunius

Differing extmaps in an offer cause the answer to be malformed

I don't think there is, well I guess CPU and bandwidth cost, but my thought was more that we might consider deprecating plan-b support and then always configure mid

Differing Codecs in offer m-lines cause the answer to be malformed

Hmm this does seem like a bug. I wonder if the #377 might fix it.

Move outbound sequence number generation to transport layer

One problem with this suggestion is that `TrackLocalStaticSample` has a way to propagate dropped packets via sequence number gaps which would break https://github.com/webrtc-rs/webrtc/blob/5612d59869e1a4b8d991ab129ab27103c2975f5b/webrtc/src/track/track_local/track_local_static_sample.rs#L55-L60

Improve NACK responder

#313 WIP take on this

Data channel fails to send packets at a frequently speed when works as a rtc server and connected by a browser.

Excellent research! Sounds like your changes are promising @KillingSpark. Please roll it up into PRs for review

Data channel fails to send packets at a frequently speed when works as a rtc server and connected by a browser.

@KillingSpark is there a specific order of merging these that would be simpler than the others?

Data channel fails to send packets at a frequently speed when works as a rtc server and connected by a browser.

Also, can you please add changelog entries in your PRs?

Data channel fails to send packets at a frequently speed when works as a rtc server and connected by a browser.

@melekes would you mind helping with some reviews? You have a more subject matter expertise than me in this area

Data channel fails to send packets at a frequently speed when works as a rtc server and connected by a browser.

Btw, worth keeping in mind how this work intersects with https://github.com/webrtc-rs/webrtc/issues/136 and a whether this potential move to a sans-IO version of SCTP helps improve the performance problems. In any...

Change `send_json` `data` argument

Can do!