Anton Bukov

Results 268 comments of Anton Bukov

@zemse maybe it was selector collision and wrong argument types?

Hi, `--contract` flag decreases speed due one more hash computation, moreover check out Settings => Battery => Energy Saving option, if enabled it limits speed significantly.

Take a look at the thing we built on Ethdam.com: https://github.com/1inch/address-token https://github.com/1inch/ERADICATE3 https://opensea.io/collection/1inch-address-nft-1 Gonna redeploy it one more time with improved `attributes`.

Interesting fact, that @1inch team started using `transient` keyword in Solidity in Dec 2023: [1inch/solidity-utils/.../BySig.sol#L50](https://github.com/1inch/solidity-utils/blob/cdb7d95d108c354a22b59a1b2be8e708251d9450/contracts/mixins/BySig.sol#L50) Can't wait to uncomment `transient` data location.

Any plans to have `transient` modifier for variables?

@Saw-mon-and-Natalie @hrkrshnn I see some CI items failed, do you think merging latest `develop` branch back to the branch would help with that?

One more important question is how to handle this case: ``` contract C1 { struct S1 { uint256 x; } } contract C2 { struct S1 { uint256 x; }...

@hrkrshnn rebasing helped with the failing CI items. Could you elaborate what is semantic tests how is it different from tests I already wrote. Not sure what this means, but...

@hrkrshnn it seems this one is not correct: > 7. A test for a type(S).typehash where S is recursive, for example struct S { S[] s; }. This should be...