Keith Wall
Keith Wall
> > > Thanks @k-wall. > > > > > > > > > > > > > > I'm generally happy but not sure its ready to merge as...
@robobario @SamBarker please take another look. @tombentley I'd like to land this PR soon (hopefully for 0.9.0 if it becomes ready). I'd also like to avoid a car crash with...
@tombentley thanks - that sounds reasonable. I'll give that a go.
@tombentley that refactorings made. @robobario can I ask for one more review of the last changes I'm hoping we are able to ship this Monday.
Currently the implementation makes use of `io.apicurio.schema.validation.json.JsonValidator#JsonValidator(java.util.Map, java.util.Optional)`. I see that https://github.com/Apicurio/apicurio-registry-schema-validation supports both Protobuf and JSONSchema, but no Avro. Wonder what it is would take to add Avro? @carlesarnal...
@robobario let's rephrase to talk about the problem first, then describe some possible solutions.
> If I recall correctly these classes address the issue that the CRD-> java code generation would generate distinct classes for each of these very similar types of objects that...
I think we should move this to a production module and commit, perhaps as simple-audit-logger, marked as preview, with a couple of tests. My reasons are twofold: 1. It'd be...
@tombentley overall, I like the Java APIs and ACL rule format you are proposing. > I realise that this PR is waaaay too big to review in reasonable depth. I'm...